Skip to content

src: refactor sqlite backup job#62732

Open
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:refactor-sqlite-backup-job
Open

src: refactor sqlite backup job#62732
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:refactor-sqlite-backup-job

Conversation

@geeksilva97
Copy link
Copy Markdown
Contributor

@geeksilva97 geeksilva97 commented Apr 14, 2026

This PR improves code of BackupJob class in sqlite codebase.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 14, 2026
@geeksilva97 geeksilva97 marked this pull request as ready for review April 14, 2026 15:27
@geeksilva97 geeksilva97 force-pushed the refactor-sqlite-backup-job branch from 62cbb93 to 6c11173 Compare April 14, 2026 15:38
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (24b1650) to head (6c11173).
⚠️ Report is 642 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62732      +/-   ##
==========================================
+ Coverage   88.52%   89.67%   +1.14%     
==========================================
  Files         704      706       +2     
  Lines      208863   218120    +9257     
  Branches    40335    41730    +1395     
==========================================
+ Hits       184905   195594   +10689     
+ Misses      15928    14441    -1487     
- Partials     8030     8085      +55     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.85% <100.00%> (+0.67%) ⬆️

... and 397 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants